| Author | ![[]](/git/avatar/c50933ca2aa61e0fe2c43d46bb6b59cb_avatar){kind=avatar} Andy Green <andy@warmcat.com> 2026-10-04 07:36 UTC |
| Committer | Andy Green <andy@warmcat.com> 2026-10-04 20:05 UTC |
| Tree | b38d0a2e6e085ed6ff78019f914ae9748c91c0c6 |
web: don't deref a NULL vhd at PROTOCOL_DESTROY If PROTOCOL_INIT fails, lws frees the vhd but PROTOCOL_DESTROY still comes, and we used it to close the event dbs regardless. Same as sai-server had. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> | |
diff --git a/src/web/w-comms.c b/src/web/w-comms.c index fa1bd45..aa151b5 100644 --- a/src/web/w-comms.c +++ b/src/web/w-comms.c @@ -417,6 +417,9 @@ w_callback_ws(struct lws *wsi, enum lws_callback_reasons reason, void *user, return 0; case LWS_CALLBACK_PROTOCOL_DESTROY: + /* we may have failed init, and lws freed the vhd */ + if (!vhd) + goto passthru; saiw_event_db_close_all_now(vhd); lws_struct_sq3_close(&vhd->pdb); goto passthru;